Skip to content

fix(desktop): release script - #6060

Merged
Sg312 merged 5 commits into
stagingfrom
fix/desktop-release
Jul 29, 2026
Merged

fix(desktop): release script#6060
Sg312 merged 5 commits into
stagingfrom
fix/desktop-release

Conversation

@Sg312

@Sg312 Sg312 commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Desktop release fixes, plus the sim side of the mothership validation_error incident fix: VFS grep now truncates oversized matched/context lines at 2K chars (a minified single-line file — workflow JSON, persisted tool results — otherwise returns whole as one "match"). Also syncs the generated mothership contract mirrors (user_table select-column descriptions from mothership #373, which were never regenerated on the sim side).

Type of Change

  • Bug fix

Testing

  • Manual verification of the desktop release flow
  • New vitest cases for grep line truncation (matched + context lines); operations.test.ts 21/21 pass
  • Contract mirrors verified by regenerating against the companion mothership branch (bun run mship:generate → clean)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Companion PR

Companion: https://github.com/simstudioai/mothership/pull/379

@Sg312
Sg312 requested a review from a team as a code owner July 29, 2026 19:50
@vercel

vercel Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 29, 2026 11:18pm

Request Review

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Fixes desktop share packaging and production origin migration.

  • Adds per-channel package:share (identity, artifact names, sequential builds) via scripts/channels.ts and package-share.ts.
  • Rewrites stored https://sim.ai → https://www.sim.ai on settings load and persists immediately to keep persist:sim and fix social-login classification.
  • Stops overriding the Dock icon for packaged macOS apps; only unpackaged electron . sets channel PNG icons.
  • Adds/extends channel-identity and config tests for the above.

Confidence Score: 3/5

Not fully safe to merge until setOrigin also applies the apex origin rewrite, or users who enter https://sim.ai stay broken until restart.

Load-time migration and share packaging look correct and well tested, but setOrigin can still persist the apex production origin and immediately drive the wrong cookie partition and social-login classification for the rest of that session.

Files Needing Attention: apps/desktop/src/main/config.ts (setOrigin)

Important Files Changed
Filename Overview
apps/desktop/scripts/package-share.ts Sequential multi-channel share packager with correct origin baking, productName/appId overrides, and artifact naming.
apps/desktop/scripts/channels.ts Build-time channel identity table mirrored to runtime channelForOrigin/APP_NAME_FOR_CHANNEL.
apps/desktop/src/main/config.ts Apex origin rewrite on load is sound; setOrigin still skips canonicalOrigin so apex can be reintroduced until restart.
apps/desktop/src/main/index.ts Dock icon set only when unpackaged on Darwin to avoid soft Retina packaged icons.
apps/desktop/package.json package:share now runs the new TypeScript packager script.

Comments Outside Diff (1)

  1. apps/desktop/src/main/config.ts, line 329-339 (link)

    P1 setOrigin skips apex rewrite

    When setOrigin is called with https://sim.ai, it stores the validated apex origin without canonicalOrigin, so until restart getOrigin stays on the apex, partitionForOrigin leaves persist:sim, and social login is classified as an integration connect instead of the system-browser handoff.

Reviews (1): Last reviewed commit: "fix" | Re-trigger Greptile

@github-actions github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

  • ❌ simstudioai/mothership#379 — OPEN, not merged (targets staging) — fix(validation_error): tool-result context blowups, recovery, provider misclassi

@Sg312 Sg312 changed the title fix(desktop): release fix(desktop): fix release script + validations Jul 29, 2026
@Sg312 Sg312 changed the title fix(desktop): fix release script + validations fix(desktop, copilot): desktop release fixes, grep output cap, contract mirror sync Jul 29, 2026
@Sg312 Sg312 changed the title fix(desktop, copilot): desktop release fixes, grep output cap, contract mirror sync fix(desktop): desktop release fixes, grep output cap, contract mirror sync Jul 29, 2026
@Sg312 Sg312 changed the title fix(desktop): desktop release fixes, grep output cap, contract mirror sync fix(desktop): release Jul 29, 2026
@Sg312 Sg312 changed the title fix(desktop): release fix(desktop): release script Jul 29, 2026
@Sg312
Sg312 merged commit 1a23438 into staging Jul 29, 2026
25 checks passed
@waleedlatif1 waleedlatif1 mentioned this pull request Jul 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sg312